Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pass to print pr.sources to a SARIF file #749

Merged
merged 10 commits into from
Nov 22, 2024
Merged

Add pass to print pr.sources to a SARIF file #749

merged 10 commits into from
Nov 22, 2024

Conversation

frabert
Copy link
Contributor

@frabert frabert commented Nov 21, 2024

No description provided.

@frabert frabert force-pushed the frabert/parser-to-sarif branch 2 times, most recently from 03846df to a50d889 Compare November 21, 2024 16:10
@trailofbits trailofbits deleted a comment from github-actions bot Nov 21, 2024
@frabert frabert force-pushed the frabert/parser-to-sarif branch 4 times, most recently from 934cf33 to 808afb2 Compare November 22, 2024 10:44
@frabert frabert changed the title Frabert/parser to sarif Add pass to print pr.sources to a SARIF file Nov 22, 2024
@frabert frabert marked this pull request as ready for review November 22, 2024 11:16
@frabert frabert requested a review from xlauko as a code owner November 22, 2024 11:16
@frabert
Copy link
Contributor Author

frabert commented Nov 22, 2024

I had to change the name from detect-parsers to vast-detect-parsers in order for it to be recognized correctly by lit

xlauko
xlauko approved these changes Nov 22, 2024
View reviewed changes
tools/vast-detect-parsers/ParserSourceDetector.cpp Outdated Show resolved Hide resolved
tools/vast-detect-parsers/SarifPasses.hpp Outdated Show resolved Hide resolved
tools/vast-detect-parsers/main.cpp Outdated Show resolved Hide resolved
@xlauko xlauko merged commit b6f7c60 into master Nov 22, 2024
3 checks passed
@xlauko xlauko deleted the frabert/parser-to-sarif branch November 22, 2024 15:03
@github-actions GitHub Actions
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v19.1.1) reports: 1 concern(s)

  • include/vast/Conversion/Parser/Passes.hpp:19:14: error: [clang-diagnostic-error]

    'vast/Conversion/Parser/Passes.h.inc' file not found

       19 |     #include "vast/Conversion/Parser/Passes.h.inc"
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlauko xlauko xlauko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frabert @xlauko